feat: add static lifetime to emission amounts calculation #4851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this doesn't seem right |
hansieodendaal
force-pushed
the
ho_static_lifetime
branch
from
0b6e395 to
bdb1dd1
Compare
CjS77
added
P-acks_required
The definition for |
|
yeah I think the original struct is sus, but this method is fine (when you take the original struct into account) |
stringhandler
approved these changes
Oct 25, 2022
CjS77
removed
the
P-reviews_required
|
Yeah, bad code smell |
|
Oh, this is a reference to the decay parameters, which are in fact static |
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Nov 7, 2022
* development: (52 commits) chore: better help for seed-words command (tari-project#4885) fix(ci): resolve windows binary builds (tari-project#4883) fix(ci): correct ARM64 builds (tari-project#4876) fix(comms/peer_manager): fix possible panic in offline calc (tari-project#4877) feat!: impl final tari pow algorithm (tari-project#4862) fix(ci): selectively revert resolver for arm64 builds (tari-project#4871) chore(deps): bump actions/checkout from 2 to 3 (tari-project#4873) fix: delete orphans if they exist (tari-project#4868) chore: replace manual implementation of char methods (tari-project#4864) chore: fix potentially buggy split of string into lines (tari-project#4863) fix(ci): update GHA set-output plus dependabot schedule for GHA (tari-project#4857) fix(base-node): use less harsh emoji for unreachable node (tari-project#4855) fix(core): add txo version checks to async validator (tari-project#4852) feat: add static lifetime to emission amounts calculation (tari-project#4851) v0.38.8 feat: add opcode versions (tari-project#4836) fix: remove clear_on_drop dependency (tari-project#4848) fix(base-node): use Network::from_str to parse network in cli (tari-project#4838) ci: remove circleci test: add cucumber critical (tari-project#4823) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a static lifetime to
emission_amountscalculation. This is needed if thepub fn emission_amountswill be called from an external client.Motivation and Context
The
&'[u64]return value was at odds with theemission_decay: &'static [u64]definition.How Has This Been Tested?
Unit tests
External client