feat: better FFI feedback from transaction validation #4827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CjS77
added
P-acks_required
CjS77
reviewed
Oct 19, 2022
|
utACK |
CjS77
added
P-merge
Co-authored-by: Cayle Sharrock <[email protected]>
stringhandler
approved these changes
Oct 24, 2022
CjS77
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This returns a u64 rather than a bool for the transaction validation callback.
Motivation and Context
Using a bool, the subscriber only knows if the validation runs through without error or failed.
By returning a u64 we give the subscriber much more information.
0: successfully
1: Already running
2: Internal failure
3: Communication failure.
How Has This Been Tested?
unit tests
Fixes: #4806