Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RS-W1099) Found manual implementation of a char::is_ascii_* method #4808

Closed
CjS77 opened this issue Oct 15, 2022 · 0 comments
Closed

(RS-W1099) Found manual implementation of a char::is_ascii_* method #4808

CjS77 opened this issue Oct 15, 2022 · 0 comments
Labels
E-good_first_issue Experience Level - Good for newcomers

Comments

@CjS77
Copy link
Collaborator

CjS77 commented Oct 15, 2022

Description

To check if a character falls under specific ascii category, consider using the builtin methods, such as, - char::is_ascii_lowercase, instead of checking if it belongs to the respective range with ('a'..='z').contains(_), and, - char::is_ascii_uppercase - char::is_ascii_digit Respectively, for using the builtin method improves readability and cognitive complexity of code.

Occurrences

There is 1 occurrence of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/tari-project/tari/issue/RS-W1099/occurrences/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-good_first_issue Experience Level - Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants