feat: add sql transactions to encumbering queries #4716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansieodendaal
force-pushed
the
ho_add_sql_transactions
branch
from
06798c9 to
096b6c7
Compare
sdbondi
approved these changes
Sep 22, 2022
sdbondi
previously approved these changes
Sep 23, 2022
hansieodendaal
force-pushed
the
ho_add_sql_transactions
branch
from
ab9f9c4 to
1ed3cf6
Compare
stringhandler
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added SQL transactions to the encumbering queries to make the entire operation atomic.
(This is a further safeguard as a follow-on to #4663.)
Motivation and Context
It is possible that an independent thread can change the same SQL data (outputs) that were selected and verified to be encumbered just before it is encumbered.
Fixes #4701.
How Has This Been Tested?
Passed unit tests
Passed cucumber tests