feat: improve txo validation logic #4689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
reviewed
Sep 16, 2022
hansieodendaal
force-pushed
the
fix_atomic_mined_height_update_error
branch
6 times, most recently
from
7fb78e7 to
e41d7b5
Compare
hansieodendaal
changed the title
sdbondi
reviewed
Sep 19, 2022
sdbondi
reviewed
Sep 19, 2022
There was a problem hiding this comment.
It is not entirely clear how this solves the problem. I would also suggest using a semaphore instead, so that we could have X threads doing validation instead of just one.
There are a lot of warnings spread across the changes making it unclear where the actual fix is.
| tokio::spawn(async move { | ||
| // Note: We do not want the validation task to be queued | ||
| let mut _lock = match validation_in_progress.try_lock() { |
There was a problem hiding this comment.
This is very difficult to understand the logic here, can it not be simplified?
stringhandler
added
P-controversial
|
Reviewing again, perhaps a semaphore is not correct here. Mutex is fine, but please try simplify the code |
- Fixed atomic mined height update error and implemented a recovery safety net for transaction output validation. - Stopped the TXO validation task from being executed in parallel as this will result in db operation on exactly the same data. - Added error int to allow ffi to distinguish between internal and communication errors (#12). Co-Authored-By: SW van Heerden [email protected]
* add specific already busy status, more comments
hansieodendaal
force-pushed
the
fix_atomic_mined_height_update_error
branch
from
9da45e7 to
5111112
Compare
stringhandler
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed atomic mined height update error and implemented a recovery safety net for transaction output validation.
Motivation and Context
Transaction validation was failing in an endless loop under certain conditions. (See #4680, #4669, #4670)
Fixes #4669
Fixes #4670
How Has This Been Tested?
Passed unit tests.
Passed cucumber tests.
System level testing.
Co-Authored-By: SW van Heerden [email protected]