Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cucumber): update get_online_status function signature in cucumber #4536

Merged

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Aug 25, 2022

Description

updates get_online_status call in js api

Motivation and Context

get_online_status returns a string ptr. #4525

How Has This Been Tested?

Cucumber tests

SWvheerden
SWvheerden previously approved these changes Aug 25, 2022
Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdbondi sdbondi force-pushed the cucumber-fx-online-status branch from fbb7adf to 2bd9633 Compare August 25, 2022 10:38
@sdbondi sdbondi changed the title fix(cucumber): add missing banned online status fix(cucumber): update get_online_status function signature in cucumber Aug 25, 2022
@stringhandler stringhandler merged commit a57eb12 into tari-project:development Aug 25, 2022
@sdbondi sdbondi deleted the cucumber-fx-online-status branch August 25, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants