fix(core)!: replace block and transaction hashes with FixedHash type #4533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SWvheerden
force-pushed
the
sw_remove_vec<u8>
branch
from
65add27 to
6e317f0
Compare
sdbondi
changed the title
sdbondi
reviewed
Aug 25, 2022
base_layer/wallet/src/output_manager_service/tasks/txo_validation_task.rs
Outdated
Show resolved
Hide resolved
base_layer/wallet/src/output_manager_service/tasks/txo_validation_task.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Stan Bondi <[email protected]>
Co-authored-by: Stan Bondi <[email protected]>
sdbondi
reviewed
Aug 25, 2022
sdbondi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the usage of Vec for all hashes except the mmr and RPC requests.
All other internal hashing now uses the
FixedHashtype.We now know each hash will always be of the correct length when processing the hash.
This gets rid of a good amount of technical debt.
How Has This Been Tested?
unit tests