feat(core): add template registration sidechain features #4470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
core-template-registration
branch
2 times, most recently
from
f0b19b0 to
9fcf00a
Compare
sdbondi
force-pushed
the
core-template-registration
branch
2 times, most recently
from
d4f67b0 to
d4c239e
Compare
sdbondi
force-pushed
the
core-template-registration
branch
from
4ff2a5c to
c9ae047
Compare
SWvheerden
reviewed
Aug 18, 2022
base_layer/core/src/transactions/transaction_components/side_chain/sidechain_features.rs
Outdated
Show resolved
Hide resolved
stringhandler
previously approved these changes
Aug 29, 2022
sdbondi
force-pushed
the
core-template-registration
branch
from
4e74f0d to
e24fc0d
Compare
stringhandler
approved these changes
Aug 29, 2022
stringhandler
pushed a commit
that referenced
this pull request
Sep 27, 2022
Description --- * Created a new `lmdb` database for template registrations, with methods for inserting and fetching them. * Base layer stores in the database all templates that appear in new blocks. * New gRPC method `GetTemplateRegistrations` to retrieve all new templates since a specific block height Motivation and Context --- In [previous work](#4470) we added template registration to UTXO sidechain features. The next step is for the base layer to store and index all template registrations that appear in blocks, as well as provide a gRPC method to retrieve them. As the main query for templates will come from the base layer scanner in the Validator Node, the gRPC query method should allow to filter all new templates since a specific block height. How Has This Been Tested? --- Manually ran the base layer and perform a gRPC query via Postman.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Code templates need to be committed to on L1.
The
binary_urlandrepo_urlfields are not validated by base node consensus because:/dns4/github.com/tcp/443/http/tari-project/tari.gitis not well-formed however the spec says it should be.Depends on #4466
Depends on #4496
How Has This Been Tested?
TODO: add cucumber tests for this output type