feat(core/consensus)!: restrict output types to only those permitted by consensus #4467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
changed the title
sdbondi
force-pushed
the
core-consensus-allowlist-output-types
branch
from
ccfd342 to
8fa2b41
Compare
stringhandler
previously approved these changes
Aug 16, 2022
stringhandler
added
the
P-conflicts
sdbondi
force-pushed
the
core-consensus-allowlist-output-types
branch
from
8fa2b41 to
15c1460
Compare
sdbondi
force-pushed
the
core-consensus-allowlist-output-types
branch
from
15c1460 to
c445624
Compare
sdbondi
added
P-conflicts
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Aug 22, 2022
* development: feat!: add hashing API use to base layer (see issue tari-project#4394) (tari-project#4447) feat(wallet): adds --stealth-one-sided flag to make-it-rain (tari-project#4508) fix!: change monero consensus encoding an update for hardfork v15 (tari-project#4492) fix(core/covenants)!: update covenants to support OutputType enum (tari-project#4472) feat(core)!: restrict output types to only those permitted by consensus (tari-project#4467)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new transaction and block validation that enforces allow-listed
OutputTypesMotivation and Context
As more
OutputTypes are added, they should only be permitted by consensus from a known height to allow for gradual network upgrades.How Has This Been Tested?
New unit test for orphan validator.
All output types are permitted for localnet/cucumber tests