fix!: burned commitment mmr calculation and cucumber prune mode #4453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix cucumber prune mode Fix cucumber header versions
stringhandler
previously approved these changes
Aug 11, 2022
SWvheerden
force-pushed
the
sw_emse_fix
branch
from
a201a7f to
a9655bf
Compare
SWvheerden
force-pushed
the
sw_emse_fix
branch
from
3e005dc to
207c89e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mmr header calculation for burned outputs
Fix cucumber prune mode
Description
Fixes the MMR root calculation for burned commitments. They were calculated correctly in the database and prune mode sync, but not during header sync calculation.
Fixes pruned mode cucumber tests. Consensus values between local net and Esmeralda were not matching.
Reduces local net header version back to 0 to match Esmeralda version.
How Has This Been Tested?
Unit and cucumber tests
fixes: #4360
fixes: #4443