feat: add hashing api to wallet secret keys #4424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
previously approved these changes
Aug 9, 2022
sdbondi
reviewed
Aug 9, 2022
|
|
||
| hash_domain!( | ||
| WalletSecretKeysDomain, | ||
| "com.tari.tari_project.base_layer.wallet.secret_keys", |
There was a problem hiding this comment.
Why add tari_project to the hash domain?
There was a problem hiding this comment.
This is to differentiate between different Tari GitHub projects.
- base_layer/wallet/src/output_manager_service/service.rs, fn hash_secret_key(...) - base_layer/wallet/src/transaction_service/service.rs, fn hash_secret_key(...)
hansieodendaal
force-pushed
the
ho_hashing_api_wallet_secret_keys
branch
from
c34a931 to
35b4136
Compare
stringhandler
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partial fulfillment for #4395:
Motivation and Context
Domain separated hashing as per the
tari_cryptohashing API is needed for secret keysHow Has This Been Tested?
Unit tests pass
Cucumber tests pass