fix(core)!: consensus hashing without extraneous length prefixes for each write #4420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Because the
H.chain(a).chain(b) != H(a||b)
property does not hold in domain-separated hashes, we cannot allow writes to call Digest::update on a domain hasher.Prefixing the length for every element is redundant with ConsensusEncoding as it is canonical and well-defined (either fixed length, length prefixed, bit-prefixed (varint)).
The PR uses a hash domain (
impl DomainSeparation
) to prepend a domain label, but uses consensus encoding directly after that so thatH.chain(a).chain(b) != H(a||b)
holds.Implementing the hashing in other languages, as in the cucumber tests, now becomes fairly trivial.
How Has This Been Tested?
Clear out mempool
cucumber used for testing and passes confirming that all javascript hashes match the rust backend.