fix: recover all known scripts #4397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SWvheerden
changed the title
sdbondi
previously approved these changes
Aug 8, 2022
| known_scripts[index].private_key.clone(), | ||
| ) | ||
| } else { | ||
| let key = PrivateKey::random(&mut OsRng); |
There was a problem hiding this comment.
I'm not a fan of this. I understand it was in the previous PR, but surely there's no data needed for this? It's misleading to store a public key without storing the secret
There was a problem hiding this comment.
What do you mean dont store the private key?
We do, its the script_key. For a Nop, the input stack will then be the public key of that private key.
So for Nop, which the else is, we store a random private key, as the script key(this is the key used to sign the input, aka script, aka K_s)
And then we store the input_data, that's required to "validly" claim the nop
There was a problem hiding this comment.
ok I see it's saved in the db, I had missed that
stringhandler
approved these changes
Aug 8, 2022
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Aug 9, 2022
* development: fix: recover all known scripts (tari-project#4397)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows the wallet to recover all known scripts.
Motivation and Context
The wallet stores a list of all known scripts and inputs required to claim them.
This PR allows the wallet to use this lest when searching for outputs to recover.
Fixes: #4231