feat!: fix kernel mutability #4377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SWvheerden
force-pushed
the
sw_fix_kernel_mut
branch
from
79a8b1d to
5607786
Compare
| let mut challenge = Challenge::new() | ||
| .chain(sum_public_nonces.as_bytes()) | ||
| .chain(total_excess.as_bytes()) | ||
| .chain(u64::from(fee).to_le_bytes()) |
There was a problem hiding this comment.
Would be better to chain(features.to_consensus_bytes()) kind of thing
There was a problem hiding this comment.
I thought the features were a substruct like in the output. I suppose this is fine
There was a problem hiding this comment.
I would say that we should use consensus encoding and domain-separated hashing here.
Might need to wait for #4381
There was a problem hiding this comment.
#4381 is merged
You can now write something like:
DomainSeparatedConsensusHasher::<TransactionHashDomain>::new("kernel")
.chain(sum_public_nonces)
.chain(total_excess)
.chain(fee)
.chain(lock_height)
.chain(features)
// NOTE that you can (and should) pass `Option`s into consensus hashing
.chain(burn_commitment)
.finalize().into()
stringhandler
previously approved these changes
Aug 3, 2022
sdbondi
reviewed
Aug 4, 2022
| let mut challenge = Challenge::new() | ||
| .chain(sum_public_nonces.as_bytes()) | ||
| .chain(total_excess.as_bytes()) | ||
| .chain(u64::from(fee).to_le_bytes()) |
There was a problem hiding this comment.
I would say that we should use consensus encoding and domain-separated hashing here.
Might need to wait for #4381
SWvheerden
force-pushed
the
sw_fix_kernel_mut
branch
3 times, most recently
from
222caef to
ce34eb4
Compare
sdbondi
reviewed
Aug 4, 2022
| const KEY = null; // optional key | ||
| const OUTPUT_LENGTH = 32; // bytes | ||
| const context = blake2bInit(OUTPUT_LENGTH, KEY); | ||
| const buff = Buffer.from(publicNonce, "hex"); | ||
| const buff2 = Buffer.from(publicExcess, "hex"); |
There was a problem hiding this comment.
I added a DomainHasher class in JS
let hash = new DomainHasher("com.tari.yada.yada.kernel")
.chain(buff).chain(buff2)
// etc.
.finalize();
SWvheerden
force-pushed
the
sw_fix_kernel_mut
branch
4 times, most recently
from
317c0c1 to
39b535d
Compare
fix kernel mutability update to rather use consensus bytes directly on features Add in mempool validation of burn
SWvheerden
force-pushed
the
sw_fix_kernel_mut
branch
from
39b535d to
3a2dead
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the kernel has a mutability issue where the public excess, features, and new optional burn commitment is not committed to in the challenge.
See issue: #4365
This is a breaking change as it changes every single kernel signature.
This changes the challenge for the kernel to include those fields. Because the kernel fields need to be signed by all parties, these needs fields must be decided at the start of the transaction. This required changes to the tx protocol as well.
How Has This Been Tested?
Running all current unit tests and all critical cucumber tests.