Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(base-node): minor fixups for hex/type parsing and long running commands #4281

Merged

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Jul 7, 2022

Description

  1. fix(base-node): make dial-peer and discover-peer run in their own task
  2. fix(base-node): when parsing hex or type commands, do string parsing first

Motivation and Context

  1. Some commands can run for a long time, while they are running they cannot be interrupted and no other commands can be issued. This change makes dial-peer and discover-peer run on their own task so that they do not block other commands.
  2. get-block 1234 would be interpreted as hex instead of as a block height. This PR fixes that.

How Has This Been Tested?

Manually

@sdbondi sdbondi force-pushed the base-node-command-fixups branch from 1d3dde3 to 361710d Compare July 7, 2022 07:58
@aviator-app aviator-app bot merged commit f910cce into tari-project:development Jul 7, 2022
@sdbondi sdbondi deleted the base-node-command-fixups branch July 7, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants