feat(comms): add or_optional trait extension for RpcStatus #4246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
comms-rpc-optional-ext
branch
from
9628d5c to
e1958a5
Compare
stringhandler
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
When RPC returns NotFound it is common that a user wants to handle that error differently. This PR makes that more ergonomic by adding the
or_optionalfunction to the RPC result that returns an Option if the NotFound status is returned. An example where NotFound this needs to be handled is in wallet utxo scanning.The lifetime changes in tor fix a compilation error that is likely from the recent upgrade to nightly rust. It is not clear why this error did not crop up sooner.
How Has This Been Tested?
New unit test