feat(wallet_ffi): add coin join and split #4218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
changed the title
sdbondi
reviewed
Jun 22, 2022
| }) | ||
| } | ||
|
|
||
| fn to_string_vec(&self) -> Result<Vec<String>, InterfaceError> { |
There was a problem hiding this comment.
The to_* functions should be marked as unsafe because they do not provide any additional safety guarantees than from_raw_parts (which is unsafe). If the data that TariVector points to is null/deallocated the Vec will be invalid and the program will crash. Moreover if the vector is mutated (as you are free to do with an owned Vec, it could be reallocated and the pointer is no longer valid.
I think the method signature should be: wont work
unsafe fn as_string_slice(&self) -> Result<&[&str], InterfaceError>
added a simple output querying function Signed-off-by: Andrey Gubarev <[email protected]>
added a simple output querying function. added an output database shortcut for easier access from the wallet context, circumventing hops through async fall-through constructs; updated all usages - `cargo test` passing. Signed-off-by: Andrey Gubarev <[email protected]>
Co-authored-by: stringhandler <[email protected]>
Co-authored-by: stringhandler <[email protected]>
fixed TariVector conversion bug found a problem in the coin_join approach, need reconsideration this commit is for review only before the final brushing/wrap-up Signed-off-by: Andrei Gubarev <[email protected]>
agubarev
force-pushed
the
testnet-dibbler
branch
from
b0640fe to
a5d9e5c
Compare
stringhandler
previously approved these changes
Jun 28, 2022
Signed-off-by: Andrei Gubarev <[email protected]>
Signed-off-by: Andrei Gubarev <[email protected]>
agubarev
force-pushed
the
testnet-dibbler
branch
from
2b7b5c0 to
be22697
Compare
Signed-off-by: Andrei Gubarev <[email protected]>
stringhandler
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding new FFI
wallet_coin_join()function and working on unit tests forwallet_coin_join()and an already existingwallet_coin_split()Motivation and Context
To enable users to join (collapse) UTXOs depending on the selected strategy, with default behavior to join outputs selected by the user.
How Has This Been Tested?
unit tests (WIP)