feat(base-node): improve contract utxo scanning #4208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
changed the title
sdbondi
force-pushed
the
core-add-block-hash-contract-index
branch
3 times, most recently
from
6d7d53f to
fbe1051
Compare
… to contract_index
…act_outputs_for_block
…outputs_for_block
sdbondi
force-pushed
the
core-add-block-hash-contract-index
branch
2 times, most recently
from
463a84b to
10af53d
Compare
…ery is out of range
sdbondi
force-pushed
the
core-add-block-hash-contract-index
branch
from
10af53d to
4487c7b
Compare
brianp
approved these changes
Jun 20, 2022
| @@ -97,6 +97,7 @@ impl DanNode { | |||
| for output in outputs { | |||
| if let Some(sidechain_features) = output.features.sidechain_features { | |||
| let contract_id = sidechain_features.contract_id; | |||
| // TODO: expect will crash the validator node if the base node misbehaves | |||
| @@ -106,11 +106,16 @@ impl BaseNodeClient for GrpcBaseNodeClient { | |||
| ) -> Result<Vec<TransactionOutput>, DigitalAssetError> { | |||
| let inner = self.connection().await?; | |||
| let request = grpc::GetConstitutionsRequest { | |||
| // TODO: pass in the last block hash that was scanned | |||
stringhandler
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
get_all_constitutionsis currently very inefficient and has to load the entire UTXO set. This PR adds a<block_hash, output_type, contract_id>index to contract_index db that allows efficient loading of contract outputs optionally filtered by type contained in a block.The get_constitutions grpc method now takes in a start_block_hash and streams utxos starting from that hash.
How Has This Been Tested?
Additional unit tests
Manually, sync on igor