Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: publication of contract update proposal acceptances #4199

Merged

Conversation

mrnaveira
Copy link
Contributor

Description

  • New gRPC method in the validator node for publishing a proposal acceptance:
    • The arguments are the contract_id and the proposal_id
    • The validator node internally uses its own public key for building the acceptance.
    • The signature of the acceptance only has a mock value for now. In the future we probably would want it to be the signature of a hash of a contract update proposal.
    • Calls the new gRPC method in the wallet to publish the transaction
  • New gRPC method in the wallet to submit a proposal acceptance. It builds and sends to the network a transaction with the corresponding type and features
  • For now, we do not check if the proposal_id is valid, or any other base layer validation.

Motivation and Context

Validator nodes need to be able to publish contract update proposal acceptances, for contracts in which they are included as committee members and an update proposal is issued.

This PR provides a gRPC method in the validator node (and a corresponding one in the wallet) to publish proposal acceptances.

How Has This Been Tested?

New integration test that publishes and mines a proposal acceptance through the new validator node gRPC endpoint

stringhandler
stringhandler previously approved these changes Jun 15, 2022
@aviator-app aviator-app bot removed the mq-failed label Jun 15, 2022
@aviator-app aviator-app bot merged commit e3b2b9b into tari-project:development Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants