feat(wallet-ffi): adds FFI wallet_get_utxos() and test_wallet_get_utxos() #4180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
changed the title
sdbondi
reviewed
Jun 10, 2022
base_layer/wallet_ffi/src/lib.rs
Outdated
| dust_threshold | ||
| ); | ||
|
|
||
| let rt = match Runtime::new() { |
There was a problem hiding this comment.
The wallet already has a runtime (it's an anti-pattern to create multiple runtimes)
wallet.runtime
There was a problem hiding this comment.
Ah, that's right, removed new runtime initialization and using:
match (*wallet)
.runtime
.block_on((*wallet).wallet.output_manager_service.get_unspent_outputs())
{
Ok(mut unblinded_outputs) => {like in other places, thanks!
sdbondi
reviewed
Jun 10, 2022
…to testnet-dibbler clippy satisfaction
…to testnet-dibbler
stringhandler
approved these changes
Jun 10, 2022
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jun 22, 2022
* testnet-dibbler: v0.32.5 chore: update toolchain and fix clippy (tari-project#4212) feat(wallet_ffi): wallet_get_utxos() (tari-project#4209) chore: bump lmdb-sys dependency (tari-project#4195) chore(deps): upgrade randomx (tari-project#4196) Bump croaring to 0.5.2 - improve cross-compile in docker bug: remove deprecated tauri config variable (tari-project#4194) feat: generate wallet ffi header file automatically (tari-project#4183) v0.32.4 feat(wallet-ffi): adds FFI wallet_get_utxos() and test_wallet_get_utxos() (tari-project#4180)
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jun 22, 2022
* testnet-dibbler: v0.32.5 chore: update toolchain and fix clippy (tari-project#4212) feat(wallet_ffi): wallet_get_utxos() (tari-project#4209) chore: bump lmdb-sys dependency (tari-project#4195) chore(deps): upgrade randomx (tari-project#4196) Bump croaring to 0.5.2 - improve cross-compile in docker bug: remove deprecated tauri config variable (tari-project#4194) feat: generate wallet ffi header file automatically (tari-project#4183) v0.32.4 feat(wallet-ffi): adds FFI wallet_get_utxos() and test_wallet_get_utxos() (tari-project#4180)
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jun 22, 2022
* development: fix clippies remove tari_core_from cbindgen build feat(miner): friendlier miner output (tari-project#4219) v0.32.5 chore: update toolchain and fix clippy (tari-project#4212) feat(wallet_ffi): wallet_get_utxos() (tari-project#4209) chore: bump lmdb-sys dependency (tari-project#4195) chore(deps): upgrade randomx (tari-project#4196) Bump croaring to 0.5.2 - improve cross-compile in docker bug: remove deprecated tauri config variable (tari-project#4194) feat: generate wallet ffi header file automatically (tari-project#4183) v0.32.4 feat(wallet-ffi): adds FFI wallet_get_utxos() and test_wallet_get_utxos() (tari-project#4180)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
To allow client app (mobile) to get a paginated list of unspent outputs, filtered by a minimum value threshold.
How Has This Been Tested?
unit test