Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hotstuff): fix bug where decide state was listening for wrong message #4160

Merged

Conversation

stringhandler
Copy link
Collaborator

Description

Fixes the decide state listening for the wrong message type

Motivation and Context

I noticed that views were timing out and that the decide state would log "Already received this message". This was happening because the leader would read the message that the replica was meant to, and then the replica would miss the message and the state would time out

How Has This Been Tested?

Manually

@mrnaveira
Copy link
Contributor

LGTM. As far as I can understand, I think the changes are consistent with what it's specified in the HotStuff original paper (the need for a Decide message type and replicas waiting for Commit message)

@aviator-app aviator-app bot merged commit fe7b304 into tari-project:development Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants