-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: contract acceptance publication #4151
feat: contract acceptance publication #4151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
The only thing missing here, ut this could be a follow up PR, is validation on these transactions.
All the stuff the base node needs to check
Correct. The work on layer 2 so far was intended to have a way to store all the features into the blockchain. We left the consensus rules/validation for future PRs, but it's something we will need to address soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, few minor comments
Description
contract_id
Motivation and Context
Validator nodes need to be able to publish contract acceptances, for contracts in which they are included as committee members.
This PR continues previous work and provides a gRPC method in the validator node (and a corresponding one in the wallet) to publish contract acceptances.
The functionality can be used in future work for implementing both auto-acceptance and manually acceptance of contract constitutions.
How Has This Been Tested?
New integration test that publishes and mines a contract acceptance through the new validator node gRPC endpoint