feat(core): add contract acceptance utxo features #4145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
approved these changes
May 27, 2022
stringhandler
added a commit
that referenced
this pull request
Jun 7, 2022
Description
---
- New gRPC method in the validator node for publishing a contract acceptance,
- The only parameter for now is the `contract_id`
- The validator node internally uses its own public key for building the acceptance.
- The signature of the acceptance only has a mock value for now. When we have contract constitutions in place, we probably would want it to be the signature of a hash of a contract constitution identification.
- Calls the new gRPC method in the wallet to publish the transaction
- New gRPC method in the wallet to submit a contract acceptance. It builds and sends to the network a contract acceptance with the corresponding flags and features
Motivation and Context
---
Validator nodes need to be able to publish contract acceptances, for contracts in which they are included as committee members.
This PR continues [previous work](#4145) and provides a gRPC method in the validator node (and a corresponding one in the wallet) to publish contract acceptances.
The functionality can be used in future work for implementing both auto-acceptance and manually acceptance of contract constitutions.
How Has This Been Tested?
---
New integration test that publishes and mines a contract acceptance through the new validator node gRPC endpoint
* add wallet method to submit an acceptance
* grpc methods to submit an acceptance
* use the new acceptance features
* fix code format
* initial version of the integration test
* new integration test that publishes an acceptance
* using variable grpc address in vn tests
* wallets publishes the acceptance tx
* asserting that the acceptance is mined
* fix integration test js code format
* compiling the vn on integration test start
* apply pr suggestions
Co-authored-by: stringhandler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ContractAcceptancestruct to the side-chain output featuresContractAcceptanceMotivation and Context
Create structs for contract acceptance in the side-chain features.
How Has This Been Tested?
ContractAcceptance