fix(ci): sort .license.ignore locally before diff #4106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringhandler
approved these changes
May 17, 2022
delta1
reviewed
May 17, 2022
|
|
||
| DIFFS=$(diff -u .license.ignore /tmp/rgtemp) | ||
| # sort the .license.ignore file as sorting seems to behave differently on different platforms | ||
| cat .license.ignore | sort > /tmp/.license.ignore |
There was a problem hiding this comment.
Suggested change
| cat .license.ignore | sort > /tmp/.license.ignore | |
| sort .license.ignore > /tmp/.license.ignore |
stringhandler
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
The license check does not always pass. I'm not really able to explain why it is flaky but on my local linux machine
it does not pass because the
sortcommand behaves slightly differently.This PR sorts the ignore file locally so that we can be sure the sorting is consistent before the diff.
How Has This Been Tested?
Manually run ./scripts/file_license_check.sh