fix(wallet): ensure block hash exists #4083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianp
force-pushed
the
validation_protocol
branch
from
3beefe5 to
e3d47f6
Compare
base_layer/wallet/src/transaction_service/protocols/transaction_validation_protocol.rs
Outdated
Show resolved
Hide resolved
brianp
commented
May 6, 2022
| response.block_hash.unwrap(), | ||
| response.confirmations, | ||
| )); | ||
| if response.block_hash.is_some() { |
There was a problem hiding this comment.
I had to look into this a bit. I was concerned is_some() protects us from passing an empty option, but I was curious what would happen if our block hash was made of just an empty Vec. Was there a chance we could have created an empty vector and as a result diesel saved it in the db as null?
It turns out this isn't a concern as diesel will use a specific null binary for an empty vector. Our example DB contains no data in the field so this must not be our current case, and likely not a concern here.
brianp
force-pushed
the
validation_protocol
branch
from
e3d47f6 to
3071969
Compare
brianp
changed the title
brianp
changed the title
brianp
changed the title
brianp
changed the title
stringhandler
changed the title
stringhandler
approved these changes
May 9, 2022
stringhandler
added a commit
that referenced
this pull request
May 10, 2022
BREAKING CHANGES --- * major config rework. Config files should be recreated (#4006) Features --- * allow network to be set by TARI_NETWORK env var ([#4073](#4073)) ([c27be5c](c27be5c)) * **collectibles:** add list assets command ([#3908](#3908)) ([5b726a6](5b726a6)) * **merge mining proxy:** check achieved Monero difficulty before submitting to Tari basenode ([#4019](#4019)) ([b09fa76](b09fa76)) * **p2p:** adds tor.forward_address setting ([#4070](#4070)) ([8c78717](8c78717)) * **tari_explorer:** add total hashrate chart ([#4054](#4054)) ([9e0ec36](9e0ec36)) Bug Fixes --- * add Environment cfg source and remove --create-id ([#4018](#4018)) ([e59e657](e59e657)) * **base-node:** assign correct base dir to tor identity ([#4081](#4081)) ([1464f8b](1464f8b)) * **dht:** saf storage uses constructs correct msg hash ([#4003](#4003)) ([e1e7669](e1e7669)) * **dht:** sets file default for DHT db ([#4030](#4030)) ([5b125e7](5b125e7)) * **dns-seeds:** use correct cloudflare resolver default ([#4029](#4029)) ([c95e589](c95e589)) * fix github integration tests ([#4008](#4008)) ([aa143c6](aa143c6)) * github actions ([#4014](#4014)) ([a03392e](a03392e)) * ignore test that timeout in github action ([#4010](#4010)) ([6c5471e](6c5471e)) * **key-manager:** remove floating point math from mnemonic code ([#4064](#4064)) ([c2d60b3](c2d60b3)) * launchpad build docker images ([#4042](#4042)) ([50e2812](50e2812)) * **launchpad:** fix config presets ([#4028](#4028)) ([1b8b274](1b8b274)) * long running and non critical github action ([#4009](#4009)) ([3b8cb8b](3b8cb8b)) * makes header consensus encoding infallible ([#4045](#4045)) ([5ebf129](5ebf129)) * only count base nodes in peers count in base node status ([#4039](#4039)) ([190d75a](190d75a)) * prevent seed peer address from being overwritten unless newer ([#4085](#4085)) ([59b76c3](59b76c3)) * support safe non-interactive mode ([#4072](#4072)) ([b34f79d](b34f79d)) * test_output_manager_sqlite_db(_encrypted) ([#4025](#4025)) ([7a6f980](7a6f980)) * update daily test configuration ([#4049](#4049)) ([b15d682](b15d682)) * **wallet:** do not prompt for password if given in config ([#4040](#4040)) ([fc1aa65](fc1aa65)) * **wallet:** ensure block hash exists ([#4083](#4083)) ([a258984](a258984)) * weird behaviour of dates in base node banned peers ([#4037](#4037)) ([7097185](7097185))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a quick data validation check before updating the database. The base node may return a response without a block_hash and the resulting db update creates an invalidatable scenario for the wallet.
Motivation and Context
An aurora wallet is failing to validate and causing problems
How Has This Been Tested?
It has not yet been tested.