feat(dht): monitor and display warning for min ratio for TCPv4 nodes #3953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
dht-warn-for-too-many-tor-nodes
branch
from
f85b007 to
1577bcf
Compare
sdbondi
force-pushed
the
dht-warn-for-too-many-tor-nodes
branch
from
1577bcf to
e2ed3e0
Compare
stringhandler
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
common.dht_minimum_desired_tcpv4_node_ratioconfigMotivation and Context
Display warning if node does not meet a configured minimum ratio. This is to warn about the potential for sybil attacks because of very low (TCPv6) or zero (Tor) cost for creating new network addresses.
How Has This Been Tested?
Manually, log warning is emitted