Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add contacts status to tui #3868

Merged
merged 3 commits into from
Feb 25, 2022
Merged

feat: add contacts status to tui #3868

merged 3 commits into from
Feb 25, 2022

Conversation

hansieodendaal
Copy link
Contributor

@hansieodendaal hansieodendaal commented Feb 23, 2022 •
edited
Loading

Description

Added the contacts liveness status to the console wallet's TUI using the recently merged contacts liveness service feature.

  Alias                   Public Key                                                       Emoji ID          Last Seen   Status   
node01 bn                 cca97dacf0667b8a94fa0e17d7449cad23b7ad59940733dca488c0eb2943ed1e 📡👾🐢..🚁🍍🌂             NeverSeen
node02 has long alias nam fa9a9b87a5d575737d8559524c62c5cccb1cc8732299560a16d4f060d7095930 🚪👖👗..🎸🍬🌞  02-24T15:49 Online   
node02 bn                 fc8488da9a83d7c851166fc0b18986155958856658d20a9819061df12ef83400 🚲🐮🐳..🍳🌀📚             NeverSeen
node03                    d258580f20f2d2b712905b8867529b02a376dc066f2c7028d67926f8bbdc1b7a 🔎🎷🎷..🍊🐜🍈 02-24T15:49 Online   
nodetest                  d60429291ef2d6a8698a1789794cbf7ce31a138d0a7bae00d857df616407cd26 🔦🌋🍟..📣🍗🏦 02-22T22:54 Offline  
│```

Motivation and Context
---
Experimental.

How Has This Been Tested?
---
System-level tests.

@hansieodendaal hansieodendaal force-pushed the ho_contacts_status_into_tui branch from 21f2b45 to 7deb409 Compare February 23, 2022 11:46
@hansieodendaal hansieodendaal changed the title feat: add contacts status to tui [WIP] feat: add contacts status to tui Feb 23, 2022
@hansieodendaal hansieodendaal force-pushed the ho_contacts_status_into_tui branch from 6a35fce to 7deb409 Compare February 24, 2022 11:22
@hansieodendaal
Add contacts status to TUI
0387cab 
- Added the contacts status to the TUI
@hansieodendaal
refactor
656b818
@hansieodendaal hansieodendaal force-pushed the ho_contacts_status_into_tui branch from 7deb409 to 656b818 Compare February 24, 2022 14:48
@hansieodendaal hansieodendaal changed the title [WIP] feat: add contacts status to tui feat: add contacts status to tui Feb 24, 2022
philipr-za
philipr-za approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@philipr-za philipr-za left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

applications/tari_console_wallet/src/ui/state/wallet_event_monitor.rs
match liveness_event.deref() {
ContactsLivenessEvent::StatusUpdated(data) => {
trace!(target: LOG_TARGET,
"Contacts Liveness Service Callback Handler event 'StatusUpdated': {}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Contacts Liveness Service Callback Handler event 'StatusUpdated': {}",
"Contacts Liveness Service event 'StatusUpdated': {}",

We are in the console_wallet so callbacks are not really relavent

@aviator-app aviator-app bot merged commit 30bf86b into tari-project:development Feb 25, 2022
@hansieodendaal hansieodendaal deleted the ho_contacts_status_into_tui branch February 26, 2022 05:38
@sdbondi sdbondi mentioned this pull request Aug 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipr-za philipr-za philipr-za approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hansieodendaal @philipr-za