Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(validator-node): committee proposes genesis block w/ instructions #3844

Merged
merged 2 commits into from
Feb 18, 2022
Merged

feat(validator-node): committee proposes genesis block w/ instructions #3844

merged 2 commits into from
Feb 18, 2022

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Feb 17, 2022 •
edited
Loading

Description

  • committee proposes genesis block/node with initial instructions as per template id
  • state db is aware of which asset it is processing
  • minor cleanup of some generics
  • error handling

Motivation and Context

The committee can propose a genesis block with init instructions and agree on a genesis block and genesis merkle root

How Has This Been Tested?

Manually

@sdbondi sdbondi force-pushed the vn-genesis-instructions branch from 919678b to 8dc6249 Compare February 17, 2022 07:16
@sdbondi sdbondi marked this pull request as draft February 17, 2022 11:51
@sdbondi sdbondi force-pushed the vn-genesis-instructions branch from 8dc6249 to 702d324 Compare February 17, 2022 13:39
@sdbondi sdbondi marked this pull request as ready for review February 17, 2022 14:34
@sdbondi sdbondi force-pushed the vn-genesis-instructions branch 2 times, most recently from 410042d to 95ce958 Compare February 17, 2022 14:39
@sdbondi sdbondi force-pushed the vn-genesis-instructions branch from 95ce958 to 7b2cabb Compare February 18, 2022 09:51
stringhandler
stringhandler approved these changes Feb 18, 2022
View reviewed changes
Copy link
Collaborator

@stringhandler stringhandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. I would use the TSpecification instead of TOutboundService in future, but not a problem now

@aviator-app aviator-app bot merged commit 68a9f76 into tari-project:development Feb 18, 2022
@sdbondi sdbondi deleted the vn-genesis-instructions branch February 18, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stringhandler stringhandler stringhandler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdbondi @stringhandler