Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show error if IPFS upload fails #3746

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Jan 25, 2022

Description

  • show error for failed file upload

Motivation and Context

File used to appear as if it was uploading forever, now an error appears

How Has This Been Tested?

Manually
image

@sdbondi sdbondi force-pushed the collectibles-upload-image-show-error branch from d9b9719 to 93dcc2e Compare January 25, 2022 12:00
Copy link
Contributor

@delta1 delta1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice LGTM, untested

@aviator-app aviator-app bot removed the mq-failed label Jan 26, 2022
@aviator-app aviator-app bot merged commit b58cf4c into tari-project:development Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants