feat: bad block list for invalid blocks after sync #3637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
core-bad-blocks-list
branch
from
6ad67db to
b215d5c
Compare
sdbondi
force-pushed
the
core-bad-blocks-list
branch
from
b215d5c to
e4e6cd3
Compare
stringhandler
previously approved these changes
Dec 1, 2021
|
Looks like a test might need updating? |
stringhandler
previously approved these changes
Dec 3, 2021
therustmonk
previously approved these changes
Dec 6, 2021
* development: fix(pruned mode)!: prune inputs, allow horizon sync resume and other fixes (tari-project#3521)
sdbondi
dismissed stale reviews from therustmonk and stringhandler
via
17fa7f4
stringhandler
approved these changes
Dec 6, 2021
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Dec 6, 2021
* development: feat: bad block list for invalid blocks after sync (tari-project#3637)
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Dec 6, 2021
* development: feat: bad block list for invalid blocks after sync (tari-project#3637)
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Dec 7, 2021
* development: feat(consensus)!: add tari script byte size limit check to validation (tari-project#3640) fix: minor improvements to available neighbouring peer search (tari-project#3598) feat: bad block list for invalid blocks after sync (tari-project#3637)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Maintain a list of "bad blocks" that should never be accepted
Remove pending headers if block sync fails to validate the block body against the (now invalid) headers.
Motivation and Context
(Partially) valid headers may become invalid (MMR) once the block body is synced. This PR removes those headers and adds the offending block to a banned block list.
How Has This Been Tested?
Some new unit tests, basic manual test