fix!: console wallet grpc_console_wallet_addresss config #3619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StriderDM
force-pushed
the
fix_console_wallet_grpc_config
branch
2 times, most recently
from
2f08c51 to
60fe449
Compare
This PR changes `grpc_console_wallet_address` to `grpc_address` and moves it into the `wallet` section of the config. Additionally it also allows a grpc address to be specified via the `--grpc-address` command line argument for the console_wallet (using standard multiaddr formatting). Update cucumber function timeout
StriderDM
force-pushed
the
fix_console_wallet_grpc_config
branch
from
60fe449 to
333addd
Compare
philipr-za
approved these changes
Nov 26, 2021
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Dec 6, 2021
* development: (29 commits) fix(pruned mode)!: prune inputs, allow horizon sync resume and other fixes (tari-project#3521) feat!: sending one-sided transactions in wallet_ffi (tari-project#3634) fix: use json 5 for tor identity (regression) (tari-project#3624) test: add operation_id to log messages (tari-project#3633) fix!: multiple monerod addresses in tari merge mining proxy (tari-project#3628) fix: get-peer command works with public key again (tari-project#3636) fix!: separate peer seeds to common.network (tari-project#3635) test: removed stress test log target (tari-project#3631) feat: removed transaction validation redundant events (tari-project#3630) feat: improve wallet responsiveness (tari-project#3625) feat: add bulletproof rewind profiling (tari-project#3618) fix!: console wallet grpc_console_wallet_addresss config (tari-project#3619) test: increase timeout in cucumber (tari-project#3621) chore: change status line (tari-project#3610) feat!: add tcp bypass settings for tor in wallet_ffi (tari-project#3615) feat: only trigger UTXO scanning when a new block event is received (tari-project#3620) feat: implement dht pooled db connection (tari-project#3596) feat: add page for detailed mempool in explorer (tari-project#3613) chore: add pub key in the dailes notify (tari-project#3612) feat: display network for console wallet (tari-project#3611) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes
grpc_console_wallet_addresstogrpc_addressand moves it into thewalletsection of the config.It also allows a grpc address to be specified via the
--grpc-addresscommand line argument for the console_wallet (using standard multiaddr formatting).Additionally, fixes a bug due to a missing config default.
How Has This Been Tested?
cargo test --all
nvm use 12.22.6 && node_modules/.bin/cucumber-js --profile "ci" --tags "not @long-running and not @broken"
manually (
cargo run --bin tari_console_wallet -- --grpc-address /ip4/127.0.0.1/tcp/18144+ bloomRPC client)