feat: implement DHT protocol versioning, includes #3243 #3377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR includes the relevant DhtHeader fields in the commitment of a Dht Message MAC signature so that they cannot be changed while in route. The header fields included in the commitment are: - Major version - Minor version - Destination - Message type - Message flags - Expiry time (if exists) - Ephemeral public key (if exists)
sdbondi
force-pushed
the
igor-network
branch
from
9f73ab9 to
4d1550c
Compare
sdbondi
changed the title
sdbondi
force-pushed
the
igor-network
branch
from
4d1550c to
220e0c1
Compare
- implements DHT protocol versioning allowing the same codebase to be used for multiple networks - DRY dht header signature construction - Pre-version 2 DHT protocol does not use the entire header in signature challenge - minor DHT builder improvements
sdbondi
force-pushed
the
igor-network
branch
from
220e0c1 to
71f53f1
Compare
stringhandler
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
used for multiple networks
signature challenge
Motivation and Context
Allow new break protocols to be introduced while old protocols still exist.
Setting the protocol version sets the DHT to speak that version, while still supporting previous versions
Closes #3243
How Has This Been Tested?
Tested discovery on weatherwax which uses versioned challenge construction