fix: reduce overly-eager connection reaping for slow connections #3308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
comms-example-stress-test-update-fix
branch
from
77aa83e to
69c2075
Compare
Connection reaping has been improved for use with slower connections: - A connection is counted as used as soon as a request for a substream has been started. - The minimum age of a connection before it can be reaped changed from 1 minute to 20 minutes - Reduces the refresh interval for pool refresh from every 30s to every 60s - Set `MissedTickBehaviour::Delay` for refresh interval, as bursting is undesired - fixes the stress_test example - fix (rare) flakiness for `dial_cancelled` comms test
sdbondi
force-pushed
the
comms-example-stress-test-update-fix
branch
from
69c2075 to
a153374
Compare
philipr-za
approved these changes
Sep 7, 2021
stringhandler
approved these changes
Sep 7, 2021
Cifko
pushed a commit
to Cifko/tari
that referenced
this pull request
Sep 10, 2021
…i-project#3308) Description --- Connection reaping has been improved for use with slower connections (network IO or slow thread scheduling): - A connection is counted as used as soon as a request for a substream has been started. - The minimum age of a connection before it can be reaped changed from 1 minute to 20 minutes - Reduces the refresh interval for pool refresh from every 30s to every 60s - Set `MissedTickBehaviour::Delay` for refresh interval, as bursting is undesired - fixes the stress_test example - fix (rare) flakiness for `dial_cancelled` comms test Motivation and Context --- Connections should not be considered unused while they are attempting to establish a substream. This typically takes < 1 second over tor, however a slow network and/or thread starvation can cause substream establishment to take many seconds. Previously, the connection would be counted as unused for that period, resulting in reaping while a substream is being established.  How Has This Been Tested? --- Basic base node test 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Connection reaping has been improved for use with slower connections (network IO or slow thread scheduling):
A connection is counted as used as soon as a request for a substream
has been started.
The minimum age of a connection before it can be reaped changed from 1
minute to 20 minutes
Reduces the refresh interval for pool refresh from every 30s to every 60s
Set
MissedTickBehaviour::Delayfor refresh interval, as bursting isundesired
fixes the stress_test example
fix (rare) flakiness for
dial_cancelledcomms testMotivation and Context
Connections should not be considered unused while they are attempting to establish a substream. This typically takes < 1 second over tor, however a slow network and/or thread starvation can cause substream establishment to take many seconds.
Previously, the connection would be counted as unused for that period, resulting in reaping while a substream is being established.
How Has This Been Tested?
Basic base node test