[DO NOT MERGE]feat: change kernel ordering #3193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Think you should update the canonical ordering in the consensus rules RFC (120) |
stringhandler
added
W-consensus_breaking
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Sep 20, 2021
Block v1 (compatible with weatherwax at all heights): - Kernel ordering using every kernel field - Input MR commits to empty serialization of bitmap Block v2 (Igor, breaking change) - Kernel ordering (tari-project#3193) - Input MR uses input hashes only without extaneous empty bitmap bytes (tari-project#3195) Network - DHT messaging protocol: On weatherwax: no change, fully compatible On all other networks: protected from header malleability
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Sep 21, 2021
Block v1 (compatible with weatherwax at all heights): - Kernel ordering using every kernel field - Input MR commits to empty serialization of bitmap Block v2 (Igor, breaking change) - Kernel ordering (tari-project#3193) - Input MR uses input hashes only without extaneous empty bitmap bytes (tari-project#3195)
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Sep 21, 2021
Block v1 (compatible with weatherwax at all heights): - Kernel ordering using every kernel field - Input MR commits to empty serialization of bitmap Block v2 (Igor, breaking change) - Kernel ordering (tari-project#3193) - Input MR uses input hashes only without extaneous empty bitmap bytes (tari-project#3195)
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Sep 21, 2021
Block v1 (compatible with weatherwax at all heights): - Kernel ordering using every kernel field - Input MR commits to empty serialization of bitmap Block v2 (Igor, breaking change) - Kernel ordering (tari-project#3193) - Input MR uses input hashes only without extaneous empty bitmap bytes (tari-project#3195)
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Sep 21, 2021
Block v1 (compatible with weatherwax at all heights): - Kernel ordering using every kernel field - Input MR commits to empty serialization of bitmap Block v2 (Igor, breaking change) - Kernel ordering (tari-project#3193) - Input MR uses input hashes only without extaneous empty bitmap bytes (tari-project#3195)
aviator-app bot
pushed a commit
that referenced
this pull request
Sep 21, 2021
… compatibility (#3372) Description --- Block v1 (compatible with weatherwax at all heights): - Kernel ordering using every kernel field - Input MR commits to empty serialization of bitmap Block v2 (Igor, breaking change) - Kernel ordering (#3193) - Input MR uses input hashes only without extaneous empty bitmap bytes (#3195) Misc - Add missing kernel order block validation - Removed unnecessary transaction body sorting in wallet, it (still) is the responsibility of the GetNewBlockTemplate to assemble a final sorted block body. Motivation and Context --- Allow consensus breaking code to be merged without hard forking weatherwax. Igor will have to be reset. To follow in subsequent PR: network breaking changes from DHT header malleability fix (#3243 ) How Has This Been Tested? --- Archival sync weatherwax node from scratch, received propagated blocks Washing machine between two weatherwax wallets
|
Changed included in #3372. Closing |
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Feb 3, 2022
Block v1 (compatible with weatherwax at all heights): - Kernel ordering using every kernel field - Input MR commits to empty serialization of bitmap Block v2 (Igor, breaking change) - Kernel ordering (tari-project#3193) - Input MR uses input hashes only without extaneous empty bitmap bytes (tari-project#3195) Network - DHT messaging protocol: On weatherwax: no change, fully compatible On all other networks: protected from header malleability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the kernel order to be on the excess signature (nonce then signature)
Motivation and Context
This locks the kernel into canonical ordering.
How Has This Been Tested?
Checklist:
developmentbranch.