From ef387d720ae1b092d0ebe4459fafc27a241368f8 Mon Sep 17 00:00:00 2001 From: Hansie Odendaal <39146854+hansieodendaal@users.noreply.github.com> Date: Mon, 27 May 2024 18:22:29 +0200 Subject: [PATCH] feat: add default message tag (#6355) Description --- Add a default message tag to `FinalSendMessageParams`. This enables the tracing of ping-pong and other messages across nodes. Motivation and Context --- - We have a related issue with ping-pong, see #6356. This tracing will assist in analysing the issue. - With transaction testing, we noticed that some messages have a zero tag; this will also help that tracing. How Has This Been Tested? --- System-level tests. What process can a PR reviewer use to test or verify this change? --- Review code. Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify --- comms/dht/src/outbound/message_params.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/comms/dht/src/outbound/message_params.rs b/comms/dht/src/outbound/message_params.rs index 269d75ddc2..2195389a48 100644 --- a/comms/dht/src/outbound/message_params.rs +++ b/comms/dht/src/outbound/message_params.rs @@ -84,7 +84,7 @@ impl Default for FinalSendMessageParams { is_discovery_enabled: false, dht_header: None, debug_info: None, - tag: None, + tag: Some(MessageTag::new()), } } }