Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: enable no_std support for tari_crypto #191

Merged
merged 12 commits into from
Aug 10, 2023

Conversation

SWvheerden
Copy link
Contributor

@SWvheerden SWvheerden commented Aug 2, 2023

This PR adds in no_std support for TariCrypto.
The following changes where made to enable this:

  • thiserror was swapped out for Snafu as thiserror does not support no_std while snafu does.
  • use std:: was changed to use core::
  • make all dependencies default-features = false
  • make BulletProofPlus an optional feature
  • make serde an optional feature
  • Make precomputed_tables optional as they require large internal memory
  • remove lazy_static as a dependency (replaced by one-cell)
  • changed sign message to use supplied RNG, and not thread_local internally

@ghpbot-tari-project ghpbot-tari-project added the CR-insufficient_context The PR body does not provide enough information to fully describe the changes requested. label Aug 2, 2023
hansieodendaal and others added 6 commits August 8, 2023 10:38
Updated "tari_bulletproofs_plus"
Updated "tari_utilities"
make RP+ optional
make get_random optional

couple random to wasm

remove serde

remove bindgen

make rand_cha_cha optional features

move rand to dev dependancy 

Revert "make rand_cha_cha optional features"

This reverts commit e553ba5.

digest optional features

sha3, blake2 optional features false

once_cell, cha cha

snafu

utilities to no default

snafu default failse

try critical features

remove std

test zero

add no_std

test

test2

test

Revert "remove lazy static"

This reverts commit a39bea5.

fix default

no std support

remove features

test

unsync

precomputed tables

Revert "Revert "remove lazy static""

This reverts commit a0abb27.

crit features

test

fmt
@SWvheerden SWvheerden force-pushed the sw_test_ledger_deps branch from fe6bb06 to ca521df Compare August 8, 2023 08:44
@SWvheerden SWvheerden changed the title [WIP] clean up Hardware requirements. feat: enable no_std support for tari_crypto Aug 8, 2023
@SWvheerden SWvheerden changed the title feat: enable no_std support for tari_crypto feat!: enable no_std support for tari_crypto Aug 8, 2023
Copy link
Contributor

@AaronFeickert AaronFeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed for cryptographic changes.

@SWvheerden SWvheerden merged commit a0e9765 into tari-project:main Aug 10, 2023
@SWvheerden SWvheerden deleted the sw_test_ledger_deps branch August 10, 2023 10:31
@SWvheerden SWvheerden mentioned this pull request Aug 10, 2023
SWvheerden added a commit that referenced this pull request Aug 10, 2023
#
[0.18.0](v0.17.0...v0.18.0)
(2023-08-10)


## ⚠ BREAKING CHANGES

* enable no_std support for tari_crypto (#191)
* move the WASM and FFI builds to seperate Repos (#193)

## Features

* enable no_std support for tari_crypto
([191](#191))
([a0e9765](a0e9765))
* fix new_generator
([192](#192))
([0d463b0](0d463b0))
* move the WASM and FFI builds to seperate Repos
([193](#193))
([053119f](053119f))
* remove unused dalek rangeproof
([184](#184))
([d21cd37](d21cd37))
* update dependancies
([185](#185))
([4c2424f](4c2424f))
* zeroize temporary scalar byte array
([188](#188))
([2147522](2147522))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR-insufficient_context The PR body does not provide enough information to fully describe the changes requested. P-acks_required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants