feat: add missing methods to Commitment signature #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bytes`] and [`from_vec`] methods
sdbondi
reviewed
Feb 22, 2023
sdbondi
reviewed
Feb 23, 2023
| /// | ||
| /// WARNING: The provided secret keys and nonces are NOT bound to the challenge. This method assumes that the | ||
| /// challenge has been constructed such that all commitments are already included in the challenge. | ||
| pub fn sign_raw<C>( |
There was a problem hiding this comment.
Why was this added? As far as I can see it's the same as sign
There was a problem hiding this comment.
Should we replace the sign function by this sign_raw, to convey the idea that we are making assumptions that the inputs are sensible ? Similarly to what was used in the SchnorrSignature, via the signature api ?
There was a problem hiding this comment.
Ah right, I think this should be in another PR because we should also add a deprecation attribute to sign which may involve a number of other changes.
stringhandler
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add [
from_vec] and [from_bytes] toCommitmentSignaturetype.