Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded build arguments #49

Open
leet4tari opened this issue May 11, 2023 · 4 comments
Open

Remove hardcoded build arguments #49

leet4tari opened this issue May 11, 2023 · 4 comments

Comments

@leet4tari
Copy link
Contributor

For cross-building environments, we hardcoded some build arguments. Would be better if we support passing the build arguments at build time and removed the hardcode arguments.

@leet4tari
Copy link
Contributor Author

Taking an idea from a project like openssl-sys, we could prefix the build arguments with lets say RANDOMXRS_, then we could strip the prefix passing all envs to cmake before build.

@humb1t
Copy link

humb1t commented Oct 30, 2024

I think I may found an issue related to that:

9.034 error: failed to run custom build command for `randomx-rs v1.3.1`
9.034
9.034 Caused by:
9.034   process didn't exit successfully: `/.../target/release/build/randomx-rs-6e57928aa930594d/build-script-build` (exit status: 101)
9.034   --- stdout
9.034   status: exit status: 1
9.034   -- The CXX compiler identification is unknown
9.034   -- Configuring incomplete, errors occurred!
9.034   See also "/.../target/release/build/randomx-rs-2b4fae279d6cdf45/out/randomx_build/CMakeFiles/CMakeOutput.log".
9.034   See also "/.../target/release/build/randomx-rs-2b4fae279d6cdf45/out/randomx_build/CMakeFiles/CMakeError.log".
9.034
9.034   --- stderr
9.034   CMake Error at CMakeLists.txt:31 (project):
9.034     The CMAKE_CXX_COMPILER:
9.034
9.034       /usr/bin/aarch64-linux-gnu-g++
9.034
9.034     is not a full path to an existing compiler tool.
9.034
9.034     Tell CMake where to find the compiler by setting either the environment
9.034     variable "CXX" or the CMake cache entry CMAKE_CXX_COMPILER to the full path
9.034     to the compiler, or to the compiler name if it is in the PATH.
9.034
9.034
9.034   thread 'main' panicked at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/randomx-rs-1.3.1/build.rs:97:9:
9.034   assertion failed: c.status.success()
9.034   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
9.034 warning: build failed, waiting for other jobs to finish...

@humb1t
Copy link

humb1t commented Oct 30, 2024

Builds in docker on x86_64 work fine.

@leet4tari
Copy link
Contributor Author

Was the build arch the same as the target arch? If not, that is where I have run into problems, but my rust is very poor and don't really know how to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants