You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Complete refactor of cmontecarlo tests was started in #530, followed by #544 (Refer checklists).
While most of the work is classified as "Done", there are a group of tests which have very complex underlying methods. They are kept under the "Difficult to Test" category block comment in test_cmontecarlo.py.
These tests are:
montecarlo_one_packet
montecarlo_one_packet_loop
montecarlo_main_loop
montecarlo_event_handler
Current implementation is in this manner:
@pytest.mark.skipif(True, reason="Yet to be written.")deftest_any_of_these_mentioned (params):
pass
One more method is untested:
macro_atom macro_atom uses certain parameters of StorageModel for calculations, which are not yet set to default values in the fixture. They should be added in and this method be tested as well. To safely close this issue, a PR is expected to have the five tests mentioned here, in passing conditions.
The text was updated successfully, but these errors were encountered:
kdexd
changed the title
test_cmontecarlo.py: Certain cmontecarlo tests are incomplete.
test_cmontecarlo.py: Some cmontecarlo tests are incomplete.
May 5, 2016
yeganer
changed the title
test_cmontecarlo.py: Some cmontecarlo tests are incomplete.
test_cmontecarlo.py: partial coverage of cmontecarlo.c
May 5, 2016
Complete refactor of cmontecarlo tests was started in #530, followed by #544 (Refer checklists).
While most of the work is classified as "Done", there are a group of tests which have very complex underlying methods. They are kept under the "Difficult to Test" category block comment in test_cmontecarlo.py.
These tests are:
montecarlo_one_packet
montecarlo_one_packet_loop
montecarlo_main_loop
montecarlo_event_handler
Current implementation is in this manner:
One more method is untested:
macro_atom
macro_atom
uses certain parameters ofStorageModel
for calculations, which are not yet set to default values in the fixture. They should be added in and this method be tested as well. To safely close this issue, a PR is expected to have the five tests mentioned here, in passing conditions.The text was updated successfully, but these errors were encountered: