Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_cmontecarlo.py: partial coverage of cmontecarlo.c #556

Closed
kdexd opened this issue May 5, 2016 · 3 comments
Closed

test_cmontecarlo.py: partial coverage of cmontecarlo.c #556

kdexd opened this issue May 5, 2016 · 3 comments
Assignees

Comments

@kdexd
Copy link

kdexd commented May 5, 2016

Complete refactor of cmontecarlo tests was started in #530, followed by #544 (Refer checklists).

While most of the work is classified as "Done", there are a group of tests which have very complex underlying methods. They are kept under the "Difficult to Test" category block comment in test_cmontecarlo.py.

These tests are:

  • montecarlo_one_packet
  • montecarlo_one_packet_loop
  • montecarlo_main_loop
  • montecarlo_event_handler

Current implementation is in this manner:

@pytest.mark.skipif(True, reason="Yet to be written.")
def test_any_of_these_mentioned (params):
    pass

One more method is untested:

  • macro_atom
    macro_atom uses certain parameters of StorageModel for calculations, which are not yet set to default values in the fixture. They should be added in and this method be tested as well. To safely close this issue, a PR is expected to have the five tests mentioned here, in passing conditions.
@kdexd kdexd changed the title test_cmontecarlo.py: Certain cmontecarlo tests are incomplete. test_cmontecarlo.py: Some cmontecarlo tests are incomplete. May 5, 2016
@kdexd
Copy link
Author

kdexd commented May 5, 2016

I just edited the title for it to fit in one line ! 😅

@yeganer yeganer changed the title test_cmontecarlo.py: Some cmontecarlo tests are incomplete. test_cmontecarlo.py: partial coverage of cmontecarlo.c May 5, 2016
@unoebauer
Copy link
Contributor

@chvogl is working on this

@unoebauer
Copy link
Contributor

@chvogl has introduced some unit tests for the C-part. Thus, closing this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants