Minor inconsistencies in Simulation object

[unoebauer]

While working on PR #440, I noticed that some simulation properties are accessed within if statements in the legacy runner but are never set before (I've already added a comment):

            elif not converged and self.converged:
                # UMN Warning: the following two iterations attributes of the Simulation object don't exist
                self.iterations_remaining = self.iterations_max_requested - self.iterations_executed
                self.converged = False

Any reason for this? While running simple tardis setups (mostly tardis_example), the calculation never enters this segment of the if statement. Still, this should be resolved.... (more of these inconsistencies may be lurking around the simulation/base.py file)

[souravsingh]

I would like to work on the issue.

[unoebauer]

Hi @ftsamis - have you done anything about this while checking out the convergence strategies?

[ftsamis]

This code has been completely rewritten as part of #652, so we should close this issue after the PR gets merged.

[ftsamis]

Fixed as part of #652.