Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move _parse_species_list to new function #2764

Open
andrewfullard opened this issue Jul 30, 2024 · 2 comments
Open

Move _parse_species_list to new function #2764

andrewfullard opened this issue Jul 30, 2024 · 2 comments
Labels
io restructure

Comments

@andrewfullard
Copy link
Contributor

https://github.com/tardis-sn/tardis/blob/f84a4be4eecdb599a3f205cac0cd0388b4d886fb/tardis/visualization/tools/liv_plot.py#L102C5-L102C19

This is very useful for other parts of TARDIS. tardis.io.util seems like a reasonable location?
@rudrakshnalbalwar
Copy link

hi @andrewfullard
I opened a PR for this issue PR #2837 could you please review it

@andrewfullard
Copy link
Contributor Author

It will be reviewed as part of our weekly review meeting on Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
io restructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewfullard @rudrakshnalbalwar