Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent warning message logging #2755

Open
DeerWhale opened this issue Jul 29, 2024 · 1 comment
Open

Inconsistent warning message logging #2755

DeerWhale opened this issue Jul 29, 2024 · 1 comment
Labels
codestyle good first issue

Comments

@DeerWhale
Copy link
Contributor

Describe the bug
logger.warn is deprecated, we should update all the warning message logging that uses logger to logger.warning Instead.

In addition, there are still several places in the TARDIS code base that use warnings package instead of logger to log the warning messages. This should be check as well to make it consistent.
@atharva-2001
Copy link
Member

Should we also be moving from warnings.warn to logger.warning?

@atharva-2001 atharva-2001 mentioned this issue Jul 29, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
codestyle good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch from logger.warn to logger.warning and other corrections atharva-2001/tardis
3 participants
@andrewfullard @DeerWhale @atharva-2001