Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plasma project #263

Closed
wkerzendorf opened this issue Mar 11, 2015 · 3 comments
Closed

Plasma project #263

wkerzendorf opened this issue Mar 11, 2015 · 3 comments

Comments

@wkerzendorf
Copy link
Member

The goal of this project is to replace the existing with a new Framework for Plasma calculations. The new Framework is more modular than the current one and allows easy implementation of additional physics. Currently this is not in the code, but is part of a branch as outlined on the ideas page.

These are the suggestions to do a PR on the plasma/restructure-branch:

  1. Get familiar with the new structure
  2. Implement the beta-sobolev calculation in a new ProcessingPlasmaProperty - a stump exists here: https://github.com/tardis-sn/tardis/pull/215/files#diff-2c2a4ed36d667e096096f9a62d21216bR127
    In the existing code they are calculated here: https://github.com/tardis-sn/tardis/blob/master/tardis/plasma_array.py#L537

Over the summer we would like to see:

  • a full test suite for the new plasma branch
  • finishing of the visualization features for the plasma
  • Implementing additional physics needed for late time spectra
@liangjiaxing
Copy link

Could the function macro_atom.calculate_beta_sobolev() be called in the new ProcessingPlasmaProperty
For example, doing something like this:

class BetaSobolev(ProcessingPlasmaProperty):
    name = 'beta_sobolev'
    def calculate(self, tau_sobolev):
        beta_sobolevs = np.zeros_like(tau_sobolevs.values)
        macro_atom.calculate_beta_sobolev(self.tau_sobolevs.values.ravel(order='F'),
                                          self.beta_sobolevs.ravel(order='F'))
        return beta_sobolevs

@wkerzendorf
Copy link
Member Author

make a PR @liangjiaxing

@unoebauer
Copy link
Contributor

@wkerzendorf: status of this? Is this still relevant after the plasma overhaul?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants