Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate level index when using continuum interaction #2442

Closed
1 of 2 tasks
AlexHls opened this issue Oct 11, 2023 · 4 comments
Closed
1 of 2 tasks

Duplicate level index when using continuum interaction #2442

AlexHls opened this issue Oct 11, 2023 · 4 comments
Assignees

Comments

@AlexHls
Copy link
Member

AlexHls commented Oct 11, 2023

Describe the bug

When enabling continuum interactions duplicate level indices appear (see screenshot), causing TARDIS to crash during the re-indexing process tardis/plasma/properties/transition_probabilities.py:362

Currently #2443 implements a bandaid fix that throws a warning. Once Carsus implemented a fix upstream, this warning should be removed and an exception should be raised instead.

To Reproduce

Screenshots

2023-10-11T15:21:24,292949360-04:00

System

  • OS:

    • GNU/Linux
    • macOS
  • Environment (conda list):

Additional context

@chvogl
Copy link
Contributor

chvogl commented Nov 30, 2023

Should be dealt with in Carsus (see carsus#384).

@chvogl chvogl closed this as completed Nov 30, 2023
@AlexHls
Copy link
Member Author

AlexHls commented Nov 30, 2023

This should stay open as a reminder to remove the warning added in #2443 once Carsus fixed the problem, and instead raise an exception. I edited the issue to reflect that.

@AlexHls AlexHls reopened this Nov 30, 2023
@chvogl
Copy link
Contributor

chvogl commented Nov 30, 2023

Is this not what #2444 is for?

@AlexHls
Copy link
Member Author

AlexHls commented Nov 30, 2023

Nevermind, I forgot about that one.

@AlexHls AlexHls closed this as completed Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants