Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable user's space triggers during rebalancing #496

Open
olegrok opened this issue Oct 15, 2024 · 1 comment
Open

Disable user's space triggers during rebalancing #496

olegrok opened this issue Oct 15, 2024 · 1 comment

Comments

@olegrok
Copy link
Contributor

olegrok commented Oct 15, 2024

Such triggers can prevent writing to spaces or handle such writes in a quite weird way. So seems vshard should disable triggers (before_replace/on_replace) that user sets to avoid such confusing behaviour.

Rebalancing is quite rare action and it can suddenly shoot even on production. For now vshard rebalancing should be explicitly tested to prevent such cases. It's not good from UX point because newcomers should deeply understand how vshard internals work.

@Gerold103
Copy link
Collaborator

Keep in mind that in the same space can be multiple buckets stored. A possible workaround is a temporary wrap of user triggers into internal triggers which would invoke the user triggers only on changes coming externally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants