Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up metrics by label #263

Closed
DifferentialOrange opened this issue Jul 9, 2021 · 0 comments · Fixed by #287
Closed

Clean up metrics by label #263

DifferentialOrange opened this issue Jul 9, 2021 · 0 comments · Fixed by #287
Labels
customer feature A new functionality

Comments

@DifferentialOrange
Copy link
Member

It is possible to unregister a whole collector with registry internal methods. But it is not possible (at least without weird for-cycles and table removes) to unregister a specific metric value.

Let's consider the following case. We have a pool of connectors and several metrics of existing connectors (e.g. status, current pending requests, process successes and errors). If connector is deleted, it is no more needed to store its metrics. it would be a good pattern to use a single collector with different labels for a single metric, but then we wouldn't be able to clean it up if needed.

@DifferentialOrange DifferentialOrange added feature A new functionality customer labels Jul 9, 2021
@kyukhin kyukhin added the teamS label Aug 13, 2021
@kyukhin kyukhin added this to the wishlist milestone Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer feature A new functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants