Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect http routes removal #246

Closed
rosik opened this issue Jun 7, 2021 · 0 comments · Fixed by #247
Closed

Incorrect http routes removal #246

rosik opened this issue Jun 7, 2021 · 0 comments · Fixed by #247
Labels
bug Something isn't working

Comments

@rosik
Copy link
Contributor

rosik commented Jun 7, 2021

metrics/cartridge/roles/metrics.lua

Lines 45 to 48 in 4a902f5

local function delete_route(httpd, name)
httpd.routes[httpd.iroutes[name]] = nil
httpd.iroutes[name] = nil
end

This code leaves gaps in httpd.routes table. It may affect other modules. See, for example, fix in Cartridge: tarantool/cartridge#1414
@rosik rosik added the bug Something isn't working label Jun 7, 2021
@rosik rosik mentioned this issue Jun 7, 2021
Merged
4 tasks
@rosik rosik closed this as completed in #247 Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix http routes removal tarantool/metrics
1 participant
@rosik