From ffeccb789ac45672897faf9653c885a66ca04e1a Mon Sep 17 00:00:00 2001 From: Tristan Zaton <50082122+coma64@users.noreply.github.com> Date: Fri, 30 Aug 2024 19:40:52 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Alexander Tulchinskiy <38702085+DerekBum@users.noreply.github.com> --- ssl.go | 4 ++-- ssl_test.go | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ssl.go b/ssl.go index 0d3b6029..e7f6b423 100644 --- a/ssl.go +++ b/ssl.go @@ -232,13 +232,13 @@ func (s *SSL) DaneGet0DaneAuthority() int { return int(C.SSL_get0_dane_authority(s.ssl, nil, nil)) } -// DaneSetFlags enables the given flags for this connection. Returns the old flags. +// DaneSetFlags enables given flags for this connection. Returns previous flags. // https://www.openssl.org/docs/man1.1.1/man3/SSL_dane_clear_flags.html func (s *SSL) DaneSetFlags(flags DaneFlags) DaneFlags { return DaneFlags(C.SSL_dane_set_flags(s.ssl, C.ulong(flags))) } -// DaneClearFlags disables flags set by DaneSetFlags. Returns the old flags. +// DaneClearFlags disables flags set by DaneSetFlags. Returns previous flags. func (s *SSL) DaneClearFlags(flags DaneFlags) DaneFlags { return DaneFlags(C.SSL_dane_clear_flags(s.ssl, C.ulong(flags))) } diff --git a/ssl_test.go b/ssl_test.go index 3c059bc2..c7e24939 100644 --- a/ssl_test.go +++ b/ssl_test.go @@ -1000,10 +1000,10 @@ func TestOpenSSLGetVersion(t *testing.T) { } if ok := ctx.SetMinProtoVersion(TLS1_3_VERSION); !ok { - t.Fatal("Failed to TLS min version") + t.Fatal("Failed to set TLS min version") } if ok := ctx.SetMaxProtoVersion(TLS1_3_VERSION); !ok { - t.Fatal("Failed to TLS max version") + t.Fatal("Failed to set TLS max version") } client, err := Client(clientConn, ctx)