Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiredep ignores bower's 'ignoredDependencies' config #249

Open
splbio opened this issue Jul 18, 2016 · 2 comments
Open

Wiredep ignores bower's 'ignoredDependencies' config #249

splbio opened this issue Jul 18, 2016 · 2 comments

Comments

@splbio
Copy link

splbio commented Jul 18, 2016

Wiredep seems to ignore the 'ignoredDependencies' config option from .bowerrc.

This is problematic as now users have to duplicate config options.

For example our .bowerrc has this:

{
  "directory": "bower_components",
  "ignoredDependencies": [
    "bootstrap"
  ]
}

However wiredep will then fail later due to:

[16:42:50] gulp-inject Nothing to inject into index.scss.
stream.js:74
      throw er; // Unhandled stream error in pipe.
      ^
Error: Error: bootstrap is not installed. Try running `bower install`.

To fix this we had to add a overrides config to our wiredep config (which took us a good hour or so to figure out):

exports.wiredep = {
//  exclude: [/\/bootstrap\.js$/],
  directory: 'bower_components',
  "overrides": {
    "angular-bootstrap-confirm": {
      "dependencies": {
        "angular": ">=1.3.0",
        "angular-sanitize": ">=1.3.0"
      }
    }
  }
};

This seems pretty error prone and slightly redundant.

We like wiredep a lot, would it be possible for wiredep to look into the .bowerrc so the extra wiredep config is not needed?

Thank you very much.

@miukki
Copy link

miukki commented Aug 7, 2016

i also have this issue!

@tomchomiak
Copy link

Having the same issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants