Delay slice()ing the listeneres

[gaearon]

Redux introduced a few optimizations in 3.x, and we now delay slice()ing listeners unless absolutely necessary, and don’t slice() them more than once per dispatch(). This project should probably adopt similar optimizations.

[tappleby]

Thanks for the heads up.

Was just looking over the redux release log an these look like the major changes:

reduxjs/redux@b7031ce
reduxjs/redux#1325
reduxjs/redux@c031c0a
reduxjs/redux@5b58608

I wonder if I can avoid duplicating this logic by wrapping the listener callback instead of reimplementing the subscribe logic.

[gaearon]

Give it a try, let me know if there’s something I can do on our side

[tappleby]

So I ended up implementing both. Not sure if wrapping the listener ends up simplifying things, still end up needing all the tests as a regression.

Direct port of redux core: 4093d5c
Experimental version: ad8935d

One idea on the redux side that could help is moving the subscription logic into a util function this library could consume: tappleby/redux@6ca7c8d

[gaearon]

Mind publishing this emitter on npm?

[tappleby]

I can, though does it make sense as a standalone package?

Also there's a bunch of emitters already on npm, wonder if it should be scoped to redux. eg redux-emitter or redux-core-emitter.

[tappleby]

So I merged the direct port (4093d5c) and released with v0.1.5. Wasnt sure the timeline for reduxjs/redux#1702, plus these optimizations will still be useful for non redux v4 users.

[gaearon]

👍